feat(core): support AICORE_SERVICE_KEY env var for credentials and rename env vars - #58
Merged
Conversation
yamaceay
force-pushed
the
feat/aicore-service-key
branch
from
August 12, 2026 15:13
2b882f6 to
0271d5b
Compare
marikaner
reviewed
Aug 13, 2026
marikaner
reviewed
Aug 13, 2026
mwien
reviewed
Aug 13, 2026
ZhongpinWang
previously requested changes
Aug 13, 2026
ZhongpinWang
left a comment
ZhongpinWang
left a comment
Contributor
There was a problem hiding this comment.
First time reviewing python SDK :)
Some comments can be addressed later when doing the actual refactoring / cleaning up.
yamaceay
changed the title
yamaceay
force-pushed
the
feat/aicore-service-key
branch
from
August 14, 2026 08:54
90d6eb6 to
6861739
Compare
ZhongpinWang
left a comment
ZhongpinWang
left a comment
Contributor
There was a problem hiding this comment.
Looks much better now! Thanks for your effort 👍
yamaceay
force-pushed
the
feat/aicore-service-key
branch
from
August 14, 2026 10:59
099e8da to
4d72a82
Compare
Co-authored-by: Zhongpin Wang <zhongpin.wang@sap.com>
Co-authored-by: Zhongpin Wang <zhongpin.wang@sap.com>
Co-authored-by: Zhongpin Wang <zhongpin.wang@sap.com>
yamaceay
force-pushed
the
feat/aicore-service-key
branch
from
August 18, 2026 10:21
806e347 to
b51e307
Compare
mwien
reviewed
Aug 18, 2026
mwien
approved these changes
Aug 25, 2026
yamaceay
enabled auto-merge (squash)
August 26, 2026 07:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to align the authentication conventions of core and gen packages more closely. Not directly applicable to base, since the definition of AI API client must remain unchanged. New unit tests are added + env vars are removed from unit tests.